Activity
From 2008-03-07 to 2008-04-05
2008-04-05
- 09:42 Defect #26: GB2312 must be treated as GB18030
- Also see <http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2008-March/014127.html>.
2008-04-03
- 09:44 Defect #59 (Won't Fix): ICONV's //IGNORE flag
- XML mandates that a character set decoding error is a well-formedness error, and therefore fatal.
- 08:23 Defect #64: Support flv-application/octet-stream as a valid Flash Video mime type
- Support flv-application/octet-stream as a valid Flash Video mime type. http://kb.adobe.com/selfservice/viewContent.do?externalId=tn_19439
2008-04-02
- 19:20 Defect #62 (Duplicate): GBK must be treated as GB18030
- Duplicate of #26. Closing.
- 18:43 Defect #62: GBK must be treated as GB18030
- GB18030, the successor to GB2312 and GBK.
- 18:23 Defect #59: ICONV's //IGNORE flag
- this iconv convert code need add //IGNORE flag when $data have illegal character. if (function_exists('iconv') && ($return = @iconv($input, $output, $data))) LIKE this code: if (function_exists('iconv') && ($return = @iconv('UTF-8', 'UTF-8/...
2008-03-31
- 15:18 Defect #57: get_favicon() throws a fatal error, cache object not being created
- From my testing it seems this problem only happens when not using cURL.
2008-03-30
- 20:53 Revision 970: Missed a couple of files in the last commit.
- Missed a couple of files in the last commit.
- 20:45 Revision 969: Adding 3 unit tests for iTunes RSS.
- Adding 3 unit tests for iTunes RSS.
- 09:04 Defect #58 (New): Compressed fsockopen data stream not decoding
- Oh, and reopening it.
- 09:03 Defect #58: Compressed fsockopen data stream not decoding
- To quote Wikipedia's "gzip page":http://en.wikipedia.org/wiki/Gzip: bq. The “Content-Encoding” header in HTTP/1.1 allows clients to optionally receive compressed HTTP responses and (less commonly) to send compressed requests. The standard itsel...
- 08:50 Defect #58: Compressed fsockopen data stream not decoding
- We can't use stuff from the PHP manual, and the license is incompatible. I was working on code for this before, anyway. And blaming IIS/6.0 is wrong. It's us who doesn't comply with the spec.
- 07:18 Defect #58 (Fixed): Compressed fsockopen data stream not decoding
- 07:16 Defect #58: Compressed fsockopen data stream not decoding
- Patched on the trunk @ r968, although I'd like it to get more testing before pushing it out to the branch.
- 07:14 Revision 968: Patching #58 although this should get more testing.
- Patching #58 although this should get more testing.
- 06:43 Defect #58: Compressed fsockopen data stream not decoding
- It appears that the gzipped data stream returned from the fsockopen request isn't decoding properly. Normally, we need to strip off the first 10 characters of the data stream (the gzip header) before passing it to gzinflate(). Some servers (I'm lo...
2008-03-29
- 18:25 Defect #57 (New): get_favicon() throws a fatal error, cache object not being created
- 18:09 Defect #57: get_favicon() throws a fatal error, cache object not being created
- When I do a get_favicon() with set_cache_location() and set_favicon_handler(), the cache class is created incorrectly (returns null). This throws a fatal error on line 1959, as it tries to access a method from the null object. Code to reproduc...
2008-03-27
- 13:08 Defect #49: text/plain should not be an allowed MIME type
- I'm moving 1.1.2 off to 2nd June (the "thank God Geoffrey's exams are over" release), and we can just ship whatever we have then, as I doubt we'll ship 1.2 before August at the earliest.
2008-03-26
- 14:17 Feature Request #10: Re-write our HTTP support from scratch
- @Rasmus: Just blindingly returning the last URL you requested isn't right either: some responses are cacheable, others are note. Notably, you have permanent redirects and temporary ones, only the former of which can be cached. If we get into a com...
- 12:08 Feature Request #10: Re-write our HTTP support from scratch
- @Geoff: well, it follows redirects correctly, which was the problem with the current implementation? Using the getRequestURL() method after a request will give you the correct URL, e.g. "http://devmaster.net/rss", "http://devmaster.net/rss/", "...
- 09:16 Feature Request #10: Re-write our HTTP support from scratch
- @Rasmus: That doesn't seem that much better than what we currently have, really. Also, it has the issue for 1.3 of not supporting PHP 4 (and this, and what this blocks, is one of the main reasons to have a 1.3 at all).
- 01:52 Feature Request #10: Re-write our HTTP support from scratch
- Are you writing your own HTTP client from the ground up? You might want to take a look at this class: [[http://code.google.com/p/php-httpclient/]] It's a self-contained HttpClient with a clean PHP5-interface. I don't know if it does everything ...
2008-03-21
- 14:36 Feature Request #53: Debug Mode
- We've talked about this before, but there should be some sort of debug mode that — when enabled — can give us useful information for debugging issues. This debug info might include: * PHP version * SimplePie/Plugin version * Versions of inst...
- 14:26 Feature Request #52: Break methods like init() and sanitize() into smaller sub-methods
- This has not yet been properly evaluated, so nothing stated here is a definitive "we need to do this", but it would likely be helpful for people extending SimplePie to be able to override smaller chunks of large methods (such as init() and sanitiz...
- 14:21 Defect #51: Ensure SimplePie_Misc::display_cached_file() works with DB caching
- Currently, SimplePie_Misc::display_cached_file() only works with file system caching. It should also work with any DB caching we implement.
- 07:11 Defect #50 (New): can't override sort_items in multifeed + merge_items can't be overridden
- 03:22 Defect #50: can't override sort_items in multifeed + merge_items can't be overridden
- The SP function "merge_items" located at line 3010 in SP111 sorts items by calling the function "sort_items" statically, preventing "sort_items" from being overridden for a custom sort by extending the SP class. To fix this, you need to replace...
2008-03-17
- 16:15 Defect #49: text/plain should not be an allowed MIME type
- So... how is this different from the 1.1.1 release other than disallowing text/plain? Is it really still a high priority, or can this now be pushed off until there are more bugs to fix?
- 16:07 Defect #49: text/plain should not be an allowed MIME type
- n00b'd. See r967.
- 16:00 Revision 967: Duplicating application/rdf+xml is the first sign of madness. Refs #49.
- Duplicating application/rdf+xml is the first sign of madness. Refs #49.
- 15:01 Defect #49: text/plain should not be an allowed MIME type
- Looking at the commits, it appears that application/rdf+xml is in the "allow" list twice. Is this correct? http://bugs.simplepie.org/repositories/diff/sp1/trunk/simplepie.inc?rev=966 http://bugs.simplepie.org/repositories/diff/sp1/branches/1.1...
- 14:27 Defect #49 (Fixed): text/plain should not be an allowed MIME type
- Applied in changeset r966.
- 14:14 Revision 966: Allow application/rdf+xml and disallow text/plain. Fixes #49.
- Allow application/rdf+xml and disallow text/plain. Fixes #49.
- 14:13 Defect #49: text/plain should not be an allowed MIME type
- text/plain was added while Ryan was doing debugging and should have never been commited, yet alone ever released. application/rdf+xml is allowable for RSS 0.90 and RSS 1.0 (and some other RSS feeds are mis-served as it, such as http://nick.typepad...
2008-03-16
- 11:52 Feature Request #43: SimplePie_Misc::error in conjunction with error_reporting level
- Updated as suggested and works perfectly. Sry, for re-posting this, I just thought a cut and paste snippet should be working without errors. And as I can't edit the first entry, here again the source. Hope this is ok. function error(...
2008-03-15
- 15:28 Revision 965: Prepping SimplePie 1.1.1 for launch.
- Prepping SimplePie 1.1.1 for launch.
- 15:24 Defect #32 (New): set_feed_url( array ) Fatal error
- 14:11 Revision 964: Merge last revision from the trunk into the branch.
- Merge last revision from the trunk into the branch.
- 13:59 Revision 963: Fixed the add_to_digg() method as per bug #30.
- Fixed the add_to_digg() method as per bug #30.
2008-03-12
- 07:07 Feature Request #43 (New): SimplePie_Misc::error in conjunction with error_reporting level
- 1.1.1 is a bug-fix only release. Moving to 1.2. What we really need to do is check that the specific $level is in error_reporting(). With that patch, even if E_USER_NOTICE wasn't in error_reporting() but E_USER_WARNING was, an E_USER_NOTICE wou...
- 07:03 Defect #2 (Verified): "blank" enclosures
- r+. r=me.
2008-03-10
- 10:31 Defect #44 (Won't Fix): memory leak
- You need to manually call the destructor. The only time when you don't is if you're running PHP 5.3-dev (which deals with circular references itself, so we don't actually need a destructor at all then).
- 05:41 Defect #44: memory leak
- Unless I'm doing something seriously wrong, there still seems to be a memory leak in SP 1.1, even after the __destruct methods were added to SP and SP item classes. As a point of reference, if you merely loop through an instantiation/unset of ...
- 05:37 Feature Request #43: SimplePie_Misc::error in conjunction with error_reporting level
- It would be niche to suppress error output if the E_USER_xxx is not set in error_reporting. Otherwise it produces a lot of unnecessary output in my case, as every non-available feed gives a log entry. I just patched the function as following: ...
2008-03-08
- 08:24 Defect #26: GB2312 must be treated as GB18030
- Actually, this is wrong: we should only be treating GB2312 as GBK.
2008-03-07
- 17:27 Defect #40: Reliance on PHP5
- FYI, this was the one I mentioned to you over IRC, that I couldn't remember.
- 11:36 Defect #42: Problem retrieving feed from Drupal 5.3 views generated feed
- I have a feed that is not reading correctly in SimplePie's with demo/minimalistic.php script (Attached modified version.) I have also tried demo/cli_test.php . The feed is http://www.bayareatango.org/special_events_rss.xml which has a 7 items...
- 11:07 Feature Request #41: Make it easier to add to, remove from, replace, or disable element and attri...
- Currently, SimplePie::strip_htmltags() and SimplePie::strip_attributes() contain a default set of elements/attributes (referred to simply as "elements" from here forward) to strip. To replace the list, you simply pass in a new array of elements, a...
- 10:51 Defect #40: Reliance on PHP5
- When using MySQL caching, we throw, on PHP 4 a _Fatal error: Call to undefined function: stripos() on line 8426_. This should just be switched to SimplePie_Misc::stripos().
Also available in: Atom