Copy

Feature Request #84

Proxy Support

Added by Proxy Pete 731 days ago. Updated 429 days ago.

Status:New Start:2008-07-28
Priority:Medium Due date:
Assigned to:- % Done:

0%
Category:HTTP
Target version:1.3

Description

The following diff adds proxy support (based up http://simplepie.org/support/viewtopic.php?id=1133) but for 1.1.1

simplepie.inc.diff - proxy diff against 1.1.1 (9.7 KB) Proxy Pete, 2008-07-28 07:36

simplepie.inc.diff - Correct Diff (9.7 KB) Proxy Pete, 2008-07-28 07:38

History

Updated by Proxy Pete 731 days ago

Might help if I diff the files the right way

Updated by Geoffrey Sneddon 705 days ago

  • Category set to HTTP
  • Status changed from Unconfirmed to New
  • Assigned to set to Geoffrey Sneddon
  • Target version set to 1.2

I'll look at this this weekend, hopefully.

Updated by Geoffrey Sneddon 705 days ago

Looking quickly:
  • Parsing the proxy URL should use our IRI class, as "[::1]:8888" is currently treated incorrectly.
  • Tabs, not spaces.
  • Braces should go on new lines.
  • Singles quotes and not double quotes should be used where reasonable (in your patch that seems mainly to be "" (i.e., an empty string).
  • Various needless comments.

Updated by Geoffrey Sneddon 625 days ago

  • Assigned to deleted (Geoffrey Sneddon)

I only assigned it to me to look at the patch…

Updated by Geoffrey Sneddon 429 days ago

  • Target version changed from 1.2 to 1.3

Also available in: Atom PDF