SimplePie 1.x

At FamilyLink.com, we also needed a list of all feeds found during the discovery process. My understanding is that even with max_checked_feeds set to a high number, there's no way to access all the discovered feeds because autodiscovery() returns after finding the first valid feed. Attached is a patch that we used to achieve this functionality.

Though the patch doesn't apply properly, I managed to get it working, however it returns duplicates, as far as I can see.

I've attached a new version of the patch which uses the feed URL as an array key to ensure no duplicates. This patch should also apply cleanly.

Ryan, that's odd. I was able to redownload simplepie.inc and the patch and apply it without errors. Good idea to prevent duplicates.

I'm patching against the svn trunk; the fact it didn't have a specified revision may have been a problem.

I'm bumping this back down to 1.2 because I expect we can get a finished patch done by then. What's the point of the feed URL being the key? Is the value a File object? (I really can't remember, though I think it is.) If it is, we don't want to actually even create that object. So, I would propose you do an isset to check that we haven't already got that URL.

Geoffrey, I believe Ryan used the URLs as keys simply to prevent duplicates as the array is populated. Later, the keys are dropped when the array is returned (return array_values($feeds)). The array values are indeed File objects.

Geoffrey, is this what you meant? Let me know, and I'll commit.

Yes, r+.

Applied in changeset r1051.