Defect #57
get_favicon() throws a fatal error, cache object not being created
| Status: | Fixed | Start: | 2008-03-29 | |
| Priority: | Medium | Due date: | ||
| Assigned to: | Ryan McCue | % Done: | 0% |
|
| Category: | Cache | |||
| Target version: | 1.2 | |||
| Affected Version: | trunk |
PHP Version: | 5.2.5 |
|
| mbstring enabled: | No |
iconv enabled: | Yes |
|
| cURL enabled: | No |
zlib enabled: | Yes |
|
Description
When I do a get_favicon() with set_cache_location() and set_favicon_handler(), the cache class is created incorrectly (returns null).
This throws a fatal error on line 1959, as it tries to access a method from the null object.
Code to reproduce on Windows, PHP 5.2.5 is attached.
Associated revisions
Send the location path to SimplePie_Cache_File unparsed. Fixes #57
History
Updated by Ryan Parman 851 days ago
- Status changed from Unconfirmed to New
- Assigned to set to Ryan Parman
Updated by Michael Shipley 849 days ago
From my testing it seems this problem only happens when not using cURL.
Updated by Ryan McCue 794 days ago
- File cache-windows.diff added
I've added a patch to show how b0rked the cache creating on Windows actually is. Probably a better way to handle cache creation anyway.
Updated by Ryan Parman 792 days ago
- Assigned to changed from Ryan Parman to Ryan McCue
Make sure this fix is backported to the 1.1.x branch.
Updated by Geoffrey Sneddon 637 days ago
Ryan, does this even exist on 1.1? All this code changed from 1.1 to 1.2.
Updated by Geoffrey Sneddon 637 days ago
- Status changed from New to Fixed
- Target version changed from 1.1.2 to 1.2
I think not. Why was this ever set to 1.1.2?