Defect #51
Ensure SimplePie_Misc::display_cached_file() works with DB caching
| Status: | Fixed | Start: | 2008-03-21 | |
| Priority: | High | Due date: | ||
| Assigned to: | Michael Shipley | % Done: | 0% |
|
| Category: | Cache | |||
| Target version: | 1.2 | |||
| Affected Version: | trunk |
PHP Version: | 5.2.5 |
|
| mbstring enabled: | Yes |
iconv enabled: | Yes |
|
| cURL enabled: | Yes |
zlib enabled: | Yes |
|
Description
Currently, SimplePie_Misc::display_cached_file() only works with file system caching. It should also work with any DB caching we implement.
History
Updated by Geoffrey Sneddon 780 days ago
- Status changed from Unconfirmed to New
- Priority changed from Medium to High
- Affected Version changed from 1.1.1 to trunk
Updated by Michael Shipley 722 days ago
Proposed patch: add call_user_func($cache_name_function,$identifier_url)
@ -8921,7 +8921,7 @
- $cache = call_user_func(array($cache_class, 'create'), $cache_location, $identifier_url, $cache_extension);
+ $cache = call_user_func(array($cache_class, 'create'), $cache_location, call_user_func($cache_name_function,$identifier_url), $cache_extension);
Contrary to what the function description says, $cache_name_function is still needed here to encode the filename for both the file based and mysql based caching to work.
Updated by Geoffrey Sneddon 705 days ago
- Assigned to changed from Ryan Parman to Michael Shipley
Michael Shipley wrote:
Proposed patch: add call_user_func($cache_name_function,$identifier_url)
@ -8921,7 +8921,7@ - $cache = call_user_func(array($cache_class, 'create'), $cache_location, $identifier_url, $cache_extension); + $cache = call_user_func(array($cache_class, 'create'), $cache_location, call_user_func($cache_name_function,$identifier_url), $cache_extension);Contrary to what the function description says, $cache_name_function is still needed here to encode the filename for both the file based and mysql based caching to work.
Go ahead and commit that.
Updated by Geoffrey Sneddon 659 days ago
- Status changed from New to Fixed