Copy

Defect #2

"blank" enclosures

Added by Geoffrey Sneddon 942 days ago. Updated 904 days ago.

Status:Verified Start:2008-01-05
Priority:High Due date:
Assigned to:Geoffrey Sneddon % Done:

0%
Category:Enclosures
Target version:1.1.1
Affected Version:

1.1

 PHP Version:

5.2.3
mbstring enabled:

No

 iconv enabled:

No
cURL enabled:

No

 zlib enabled:

No

Description

In 1.1, for example in the online demo, every single feed item is coming up with a blank, bogus enclosure. I tracked this down to revision 921: "Fixed Media RSS bug where an enclosure/media:content was required before supporting ancillary Media RSS elements." It looks to me like that bug fix caused a regression. What I don't understand why this code would be pushing a "blank" enclosure onto the array if the size is 0.

2.diff (1.4 KB) Geoffrey Sneddon, 2008-02-03 11:35

Associated revisions

Revision 951
Added by Geoffrey Sneddon 941 days ago

Merge in r935/r936 and part of r937 into 1.1, fixes #2.

History

Updated by Geoffrey Sneddon 941 days ago

  • Status changed from Fixed to Verified

Updated by Geoffrey Sneddon 941 days ago

Fixed in trunk r935 and r936 by Ryan.

Updated by Geoffrey Sneddon 941 days ago

  • Status changed from Verified to New
  • Assigned to changed from Steve Minutillo to Geoffrey Sneddon

Needs to be patched in 1.1.1; reopening.

Updated by Geoffrey Sneddon 941 days ago

Can someone please verify the fix? Steve?

Updated by Geoffrey Sneddon 904 days ago

  • Status changed from Fixed to Verified
  • Affected Version set to 1.1
  • mbstring enabled set to No
  • iconv enabled set to No
  • cURL enabled set to No
  • zlib enabled set to No

r+. r=me.

Also available in: Atom PDF